[AKS] Add Kaito preview CLI flags#6931
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter enable_ai_toolchain_operator |
||
| aks update | cmd aks update added parameter disable_ai_toolchain_operator |
||
| aks update | cmd aks update added parameter enable_ai_toolchain_operator |
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
|
AKS |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
- Fix failed Static Analysis
- Fix failed UT
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
helayoty
force-pushed
the
aks-ai-toolchain-operator
branch
from
b9aaf9c to
464b3eb
Compare
helayoty
force-pushed
the
aks-ai-toolchain-operator
branch
5 times, most recently
from
2ab0893 to
e564962
Compare
|
Please fix CI issues. |
helayoty
force-pushed
the
aks-ai-toolchain-operator
branch
from
e564962 to
ce604dd
Compare
helayoty
force-pushed
the
aks-ai-toolchain-operator
branch
from
ce604dd to
4d330ee
Compare
helayoty
requested review from
AllyW,
ReaNAiveD,
StrawnSC,
calvinhzy,
jsntcy,
kairu-ms and
necusjz
as code owners
helayoty
force-pushed
the
aks-ai-toolchain-operator
branch
5 times, most recently
from
e96a4e5 to
fdba688
Compare
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
The change generally looks good.
Queued live test to validate the change.
Please fix failed CI checks.
|
To bypass option_length_too_long, update |
helayoty
force-pushed
the
aks-ai-toolchain-operator
branch
2 times, most recently
from
233a26c to
ad1ab86
Compare
|
The live test failed, option in update command not working as expected |
@FumingZhang Passed now. Please check the latest run. |
|
Glad to see the test passed in staging env, however, staging env is not public facing, but aks-preview is. Can you wait for the server-side fix to be deployed to all regions in global cloud at least before releasing the aks-preview changes? Publishing aks-preview is on-demand and instant https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=85538405&view=results BTW, there's a comment tread discussing the new version naming pattern. See #7151 (comment) |
helayoty
force-pushed
the
aks-ai-toolchain-operator
branch
3 times, most recently
from
df59bac to
e7c6297
Compare
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
helayoty
force-pushed
the
aks-ai-toolchain-operator
branch
from
e7c6297 to
247340d
Compare
Signed-off-by: Heba Elayoty <[email protected]>
helayoty
force-pushed
the
aks-ai-toolchain-operator
branch
from
247340d to
698c4c6
Compare
Co-authored-by: Yan Zhu <[email protected]>
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=127156&view=results |
6 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.